Guosmilesmile commented on code in PR #18303:
URL: https://github.com/apache/iceberg/pull/18303#discussion_r4413967965
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -224,6 +244,7 @@ private void commitPendingRequests(
String branch,
NavigableMap<Long, List<CommitRequest<DynamicCommittable>>>
commitRequestMap,
String newFlinkJobId,
+ @Nullable String sinkId,
Review Comment:
Thanks for pointting out. V1/V2 committables use the jobId as sinkId, so
it's never null and V3 no longer needs a presence flag. Make the code simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
