zeroshade commented on code in PR #2353:
URL: https://github.com/apache/iceberg-go/pull/2353#discussion_r4415166607
##########
catalog/hive/hive.go:
##########
@@ -375,9 +373,7 @@ func (c *Catalog) CreateView(ctx context.Context,
identifier table.Identifier, v
maps.Copy(ioProps, cfg.Properties)
}
- createdView, err := view.CreateViewWithIOProperties(
- ctx, catalogName, identifier, freshSchema, representation,
defaultNS, loc, ioProps, cfg.Properties,
- )
+ createdView, err := view.CreateViewFromVersion(ctx, identifier,
freshSchema, version, loc, ioProps, cfg.Properties)
Review Comment:
Non-blocking: new Hive views no longer get `default-catalog: "hive"` and now
keep the caller's default namespace and summary. A line under "Unreleased
compatibility notes" in `website/src/releases.md` would help anyone who relied
on the old values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
