gaborkaszab commented on code in PR #18503: URL: https://github.com/apache/iceberg/pull/18503#discussion_r4413591023
########## format/spec.md: ########## @@ -1124,6 +1126,8 @@ The snapshot summary's `operation` field is used by some operations, like snapsh For other optional snapshot summary fields, see [Appendix F](#optional-snapshot-summary-fields). +A snapshot's `key-id` and `encryption-key` fields are mutually exclusive and must not both be present. When committed while the table is at version 4 or higher, writers must store the snapshot's encryption key in `encryption-key`. Review Comment: done ########## format/spec.md: ########## @@ -2104,6 +2109,11 @@ Snapshot timestamp changes: * When committed while the table is at version 4 or higher, a snapshot's `timestamp-ms` must be strictly greater than its parent snapshot's `timestamp-ms` on the same branch. * Snapshots with no parent and snapshots that existed before a table was upgraded to v4 are not constrained. +Snapshot encryption key changes: + +* Writers must store the root manifest file's encryption key directly in the snapshot's `encryption-key` field and must not write `key-id` +* Snapshots that existed before a table was upgraded to v4 may continue to use `key-id` Review Comment: Removed "may" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
