plusplusjiajia commented on code in PR #2651:
URL: https://github.com/apache/iceberg-rust/pull/2651#discussion_r4400727436
##########
crates/iceberg/src/io/storage/config/mod.rs:
##########
@@ -121,6 +128,64 @@ impl StorageConfig {
.extend(props.into_iter().map(|(k, v)| (k.into(), v.into())));
self
}
+
+ /// Get the credentials that apply to locations under their prefixes.
+ pub fn storage_credentials(&self) -> &[StorageCredential] {
+ &self.storage_credentials
+ }
+
+ /// Add credentials that apply to locations under their prefixes.
+ ///
+ /// A factory that supports them overlays the props with the config of a
+ /// location's longest matching credential.
+ pub fn with_storage_credentials(
Review Comment:
Removed, along with `FileIOBuilder::with_storage_credentials`. Callers now
build the `StorageConfig` with the builder and pass it through the new
`FileIOBuilder::with_config`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
