rdblue commented on code in PR #18699: URL: https://github.com/apache/iceberg/pull/18699#discussion_r4419103412
########## core/src/main/java/org/apache/iceberg/ValidationWindow.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; +import java.util.Objects; +import java.util.Set; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.util.Pair; +import org.apache.iceberg.util.SnapshotUtil; + +class ValidationWindow { + private ValidationWindow() {} + + // returns newly added manifests and snapshot IDs between the starting and parent snapshots + static Pair<List<ManifestFile>, Set<Long>> validationHistory( Review Comment: Does this make sense as a generic util method? It seems like the returned values are not obvious. What would make more sense to me is to accept a `Consumer<Snapshot>` so that the caller can accumulate the data or delete manifests itself. Something like this: ```java static Set<Long> validationHistory(TableMetadata metadata, Snapshot parent, Long startingSnapshotId, Set<String> matchingOperations, Consumer<Snapshot> consumer) { Set<Long> newSnapshots = Sets.newHashSet(); Snapshot lastSnapshot = null; Iterable<Snapshot> snapshots = SnapshotUtil.ancestorsBetween(parent.snapshotId(), startingSnapshotId, metadata::snapshot); for (Snapshot currentSnapshot : snapshots) { lastSnapshot = currentSnapshot; if (matchingOperations.contains(currentSnapshot.operation())) { consumer.accept(currentSnapshot); newSnapshots.add(currentSnapshot.snapshotId()); } } ValidationException.check( lastSnapshot == null || Objects.equals(lastSnapshot.parentId(), startingSnapshotId), "Cannot determine history between starting snapshot %s and the last known ancestor %s", startingSnapshotId, lastSnapshot != null ? lastSnapshot.snapshotId() : null); return newSnapshots; } ``` I know that this PR is trying to avoid rewriting and is mostly just setting up the API and moving code around. If this suggestion doesn't fit with that more narrow goal, then I think a better option is to avoid having this class entirely and move the helper methods into `SnapshotValidator` instead of exposing them as package-private utilities that will very likely change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
