swapna267 commented on code in PR #18525:
URL: https://github.com/apache/iceberg/pull/18525#discussion_r4417863132
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableSerializerCache.java:
##########
@@ -112,17 +123,32 @@ int maximumSize() {
private class SerializerInfo {
private final String tableName;
- private final Map<Schema, RowDataSerializer> serializers;
+ private final Map<Schema, RowDataSerializer> serializersBySchema;
+ private final Map<Integer, RowDataSerializer> serializersBySchemaId;
private Map<Integer, Schema> schemas;
private Map<Integer, PartitionSpec> specs;
SerializerInfo(String tableName) {
this.tableName = tableName;
- this.serializers = Maps.newHashMapWithExpectedSize(2);
+ this.serializersBySchema = new LRUCache<>(maximumSize);
Review Comment:
Yeah there were already too many cache options, so just kept same as table
cache :) .
Will add separate one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
