abnobdoss commented on PR #853: URL: https://github.com/apache/iceberg-cpp/pull/853#issuecomment-6514437435
Apologies for the delay on this. I've come back to it a few times and gone through your comments, and I think conda is the wrong thing to target. CI will keep changing before 1.0.0, and as @wgtmac mentioned in #799 it should be easy to maintain, and @zhjwpku's comment convinced me this isn't. @manuzhang's question about Hive with bundled Thrift and @wgtmac's ask to keep at least one bundled leg get at the other problem: balancing coverage and CI time gets tricky when we still want some legs running the full from-source build. Going back to the goal in #799, I was wrong that Arrow is most of the cache pressure. It's about 15% of the sccache bytes, debug info is 60 to 80%. Each push to main saves about 10.6 GB against the 10 GB limit, so at least one entry from the previous set gets evicted, and about a quarter of jobs on main since August ran fully cold. Dropping debug info on the Debug legs (still Debug builds, asserts and -O0 stay) got that to about 4.7 GB on my fork with all tests passing, cold builds got faster too, and build types and coverage stay the same. So my leaning is to close this and open a small PR for that instead. What do you all think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
