dgvj-work commented on PR #2170: URL: https://github.com/apache/iceberg-go/pull/2170#issuecomment-6514651765
@laskoviymishka On the approval note that the expired-parent tests built manifests by hand: `TestIncrementalChangelogScanRebuildsExpiredParentFromRealWriters` on #2169 appends a data file, adds the position delete with `NewRowDelta`, and removes both with `ReplaceFiles`. After snapshot B is expired, planning from B succeeds and the deleted data file's `ExistingDeletes` includes that position delete, so `checkRemovedDeleteFiles` agrees with the writer's `removed-delete-files` summary. This branch also builds the changelog columns with `scalar.MakeArrayFromScalar`. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
