yusufyildiz34 opened a new pull request, #18710: URL: https://github.com/apache/iceberg/pull/18710
`s3.path-style-access`, `s3.dualstack-enabled`, `s3.cross-region-access-enabled`, `s3.use-arn-region-enabled` and `s3.acceleration-enabled` were only applied to the sync S3 client, so the async client used by the analytics accelerator ignored them. This adds `applyServiceConfigurations` overloads for the standard and CRT async builders, leaving the existing method's signature unchanged, and applies them in `s3Async()` of the default, `DefaultS3FileIOAwsClientFactory` and assume-role factories (Lake Formation inherits the latter). The CRT builder has no dual-stack or ARN region setting, so only path-style access, acceleration and cross-region access apply there. This refreshes the stale #16030 and #17549. Closes #14575 Test plan: new `TestAwsClientFactories` tests build each factory's async client with CRT on and off and assert that `s3.path-style-access` puts the bucket in the URL path; all six cases fail without the fix. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: fully reviewed - Prompt Summary: Fix apache/iceberg#14575 (S3 service configurations not applied to the async S3 client); the fix and its tests are generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
