laskoviymishka commented on issue #2062: URL: https://github.com/apache/iceberg-go/issues/2062#issuecomment-6518973440
@nssalian good catch, i reworded that. One thing before we rely on it: our apidiff gate flags alias moves today. I ran the pinned apidiff on a toy module that moves a type, a generic type, a const, a func and a sentinel error behind aliases. Code using the old names still builds, but every moved name is reported as an incompatible change, so after v1 the check would fail those PRs. I'll make check-api-compat.sh accept alias moves before the first one lands. On compaction: RewriteDataFiles is a method on both Table and Transaction, so moving it together with table/compaction is a now-or-/v2 call. I'd keep it where it is for v1 unless someone wants to claim the move now, since the freeze queue is already full. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
