ebyhr commented on code in PR #4199:
URL: https://github.com/apache/iceberg-python/pull/4199#discussion_r4422163610
##########
tests/table/test_inspect.py:
##########
@@ -76,6 +78,36 @@ def
test_inspect_entries_and_files_render_null_bound(catalog: InMemoryCatalog) -
assert files_metrics["upper_bound"] is None
+def test_inspect_entries_and_files_with_data_file_without_metrics(catalog:
InMemoryCatalog, tmp_path: PosixPath) -> None:
+ # column_sizes and the other metric maps are optional in a data file;
DuckDB, for one,
+ # writes data files without column_sizes.
Review Comment:
nit: The spec already makes these maps optional, so the DuckDB aside isn't
needed. Could shorten to one line: "# column_sizes and the other metric maps
are optional in a data file"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
