yusufyildiz34 opened a new pull request, #18711: URL: https://github.com/apache/iceberg/pull/18711
When the RRSA environment variables are present, `DefaultAliyunClientFactory` used RRSA credentials even if `client.access-key-id` and `client.access-key-secret` were configured, so explicit credentials, for example for cross-account access, were silently ignored. RRSA is now used only when that key pair is not fully set, matching how the AWS module prefers configured keys over auto-detection. The KMS client added in #18210 resolves credentials in the same order, so it gets the same change. This refreshes the stale #17048 by @thswlsqls. Closes #17046 Test plan: new `TestAliyunClientFactories` tests set the RRSA environment variables together with a static key pair and assert that the OSS and KMS clients use the static access key; both fail without the fix. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: fully reviewed - Prompt Summary: Fix apache/iceberg#17046 (RRSA auto-detection overrides explicit static credentials); the fix and its tests are generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
