nssalian commented on PR #18518:
URL: https://github.com/apache/iceberg/pull/18518#issuecomment-6537420724

   I the two changed classes with and without this PR against the same inputs: 
describe can now handle extract terms, and big-endian variant bounds read from 
manifests now decode and prune correctly. Looks good overall.                   
                                                                                
                       
   
   Not blocking: ExpressionParser still can't write extract terms, so the REST 
metrics reporter drops the scan report for these scans with a WARN. iceberg-go 
handles this by collapsing extract predicates to AlwaysTrue in its sanitizer 
(https://github.com/apache/iceberg-go/pull/1607). Could be a follow-up 
alongside              https://github.com/apache/iceberg/pull/15384. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to