dragonknightk commented on PR #4217: URL: https://github.com/apache/iceberg-python/pull/4217#issuecomment-6538433150
@RyanLin5967 thanks for catching this one — the failure is silent, so the branch looks fine until you actually read it (๑•̀ㅂ•́)و✧ The fix is small: +102 / −7 across four files, and most of that is tests. Five places that look up a branch head by name now fall back to main's current snapshot when the branch does not exist, matching Java. That covers append, overwrite, delete, and writes that get retried after a branch is removed concurrently. Reverting any one of the five makes a test fail. One check is red and not from this PR: `Run zizmor` flags `pypa/[email protected]` in `nightly-pypi-build.yml`, which this PR does not touch. #4216 bumps it to v1.14.3, so this should go green once that lands. @Fokko ready for review when you have a moment (´｡• ᵕ •｡`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
