dragonknightk commented on PR #4218: URL: https://github.com/apache/iceberg-python/pull/4218#issuecomment-6538908416
@RyanLin5967 thanks for flagging this one — a `count()` of 0 looks like an answer, so nothing points you at a snapshot that is simply gone (๑•̀ㅂ•́)و✧ The fix is tiny: two lines in `_plan_files_local` plus one test, +13 / −0 across two files. `plan_files()` and `count()` now raise `Snapshot not found` when the scan names an id that is not in the metadata, which is what `to_arrow()` already does. An empty table still plans to nothing, and the test pins id `0` so the check cannot be fooled by a falsy id. One check is red and not from this PR: `Run zizmor` flags `pypa/[email protected]` in `nightly-pypi-build.yml`, a file this change does not touch. #4216 bumps it to v1.14.3, so this should go green once that lands. @Fokko ready for review when you have a moment (´｡• ᵕ •｡`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
