yhyyz opened a new pull request, #18720:
URL: https://github.com/apache/iceberg/pull/18720

   Backport of #18610 to Flink 1.20 and 2.2.
   
   `EqualityConvertReader` passed generic `Record`s, which hold `java.time` 
values for temporal columns, directly to `StructLikeSerializer.serializeKey`, 
which expects Iceberg's internal representation. `ConvertEqualityDeletes` 
therefore failed with a `ClassCastException` on every cycle when the equality 
fields contained a `DATE`, `TIME`, `TIMESTAMP` or `TIMESTAMPTZ` column, which 
includes every table partitioned by a date column.
   
   The change is identical to the merged commit: a single 
`InternalRecordWrapper` built from the key schema in `open()`, the 
`serializeKey` javadoc, and the regression test 
`TestEqualityConvertReader#serializesTemporalEqualityFieldsFromDataAndDeleteFiles`.
   
   Verified locally: `org.apache.iceberg.flink.maintenance.*` tests, 
`spotlessCheck` and `checkstyle` pass for both `flink/v1.20` and `flink/v2.2`.
   
   Related to #18609.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to