gtrettenero commented on PR #18724: URL: https://github.com/apache/iceberg/pull/18724#issuecomment-6542643980
I put a JMH benchmark for this change in a separate PR to keep this one focused: https://github.com/gtrettenero/iceberg/pull/2. The results, setup, and reproduction steps are in that PR's description. Through the real `S3FileIO` against a local S3-compatible server, the change cuts `GetObject` requests per file from 2 to 1 for the footer and from 3 to 2 for a full row-group read. It makes no difference for footers larger than 64 KiB; see the question on `FOOTER_READ_SIZE`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
