Copilot commented on code in PR #1078:
URL: https://github.com/apache/iceberg-cpp/pull/1078#discussion_r4436323277
##########
.clang-tidy:
##########
@@ -41,5 +42,11 @@ CheckOptions:
value: '_'
- key: modernize-use-scoped-lock.WarnOnSingleLocks
value: 'false'
+ # misc-include-cleaner is scoped to standard-library headers only. Project
+ # headers (iceberg/) and third-party headers are ignored so the check does
+ # not demand a direct include for every symbol that an already-included
+ # project header provides (the noise that led to its removal in #708).
+ - key: misc-include-cleaner.IgnoreHeaders
+ value:
'iceberg/.*;arrow/.*;avro/.*;aws/.*;benchmark/.*;cpr/.*;curl/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;openssl/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;thrift/.*;libpq-fe\.h;mysql\.h;sqlite3\.h;utf8proc\.h;zlib\.h'
Review Comment:
The exclusions leave non-standard headers such as `zconf.h`, `sys/time.h`,
`unistd.h`, and `poll.h` eligible for diagnostics, so the check is not yet
standard-library-only. These headers are already used in the compression code
and HTTP tests, and changed code can still trigger non-standard include
diagnostics. Add the missing zlib and platform header exclusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
