mxm commented on code in PR #18717:
URL: https://github.com/apache/iceberg/pull/18717#discussion_r4442918287
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPlanner.java:
##########
@@ -791,6 +964,16 @@ && summaryCount(summary,
SnapshotSummary.ADD_EQ_DELETE_FILES_PROP) == 0) {
return false;
}
+ private boolean addsFiles(Snapshot snapshot) {
+ Map<String, String> summary = snapshot.summary();
+ return summaryCount(summary, SnapshotSummary.ADDED_FILES_PROP) > 0
+ || summaryCount(summary, SnapshotSummary.ADDED_DELETE_FILES_PROP) > 0;
Review Comment:
Generally speaking, no. But it is safe to assume these work in Java
implementations. I thought about addressing this in this PR by falling back to
the manifest list, but I realized we rely on them also in other parts of the
planner (`shouldSkip`). Should we address this in a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
