DG47 commented on PR #4131:
URL: https://github.com/apache/iceberg-python/pull/4131#issuecomment-6582768129
I'd like a review on this one from @Fokko or @kevinjqliu. It closes #4130:
data files written by PyIceberg never carried `nan_value_counts`, so the strict
metrics evaluator treated a missing count as "no NaN values" and
`Table.delete("x < 5.0")` dropped a whole file containing `[1.0, NaN]`, losing
the NaN row. The change counts NaN values for float and double columns in
`ParquetFormatWriter.write`, including nested struct fields, list elements and
map values, and skips columns whose metrics mode is `none` to match the Java
writers. Previously written files and files added through `add_files` are left
as they are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
