ShivamSharma43 commented on issue #1847: URL: https://github.com/apache/iceberg-go/issues/1847#issuecomment-6577061840
It looks like this was fixed by #1861 (merged 2026-08-26). That PR's description says "Closes #1487", which I think was meant to be #1847. #1487 is an unrelated PR, so this issue never closed automatically. I checked on current `main` (b354505): - `convertAvroValueToIcebergType` reads the raw value through `avroIntAsInt64` on every time and timestamp arm, which accepts `int32` or `int64`. No unchecked `v.(int64)` assertion is left. - `time-millis` and `timestamp-millis` now come back in microseconds: the raw value is multiplied by 1000, and decoded values go through `Duration.Microseconds()` / `UnixMicro()`. - The two regression tests from #1861 in `manifest_time_partition_test.go` pass locally: `TestTimeLogicalPartitionScaling` (all four subtests) and `TestTimestampLogicalOnMismatchedTypeDoesNotPanic`. Unless I've missed part of the report, I think this can be closed. cc @tanmayrauth @badalprasadsingh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
