pvary commented on code in PR #18674:
URL: https://github.com/apache/iceberg/pull/18674#discussion_r4441869542
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPlan.java:
##########
@@ -71,22 +74,23 @@ public boolean noOp() {
/** No-op cycle: empty file lists, sentinel staging snapshot id. */
public static EqualityConvertPlan noOp(
- Long mainSnapshotId, long triggerTimestamp, long doneTimestamp) {
+ Long mainSnapshotId, long triggerTimestamp, long doneTimestamp, long
indexGeneration) {
return new EqualityConvertPlan(
ImmutableList.of(),
ImmutableList.of(),
ImmutableList.of(),
NO_OP_STAGING_SNAPSHOT_ID,
mainSnapshotId,
triggerTimestamp,
- doneTimestamp);
+ doneTimestamp,
+ indexGeneration);
}
/**
* Cycle-start marker: a no-op plan whose done timestamp is never reached,
so consumers hold it
* until the cycle's actual plan replaces it.
*/
- public static EqualityConvertPlan cycleStart(long triggerTimestamp) {
- return noOp(null, triggerTimestamp, Long.MAX_VALUE);
+ public static EqualityConvertPlan cycleStart(long triggerTimestamp, long
indexGeneration) {
+ return noOp(null, triggerTimestamp, Long.MAX_VALUE, indexGeneration);
Review Comment:
What is the meaning of the `indexGeneration` for the `cycleStart`? Do we use
it anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
