joyhaldar commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r4450847650
##########
data/src/test/java/org/apache/iceberg/data/ReadFormatModelTests.java:
##########
@@ -370,19 +418,15 @@ void testReaderBuilderProjection(FileFormat fileFormat)
throws IOException {
writeGenericRecords(fileFormat, fullSchema, genericRecords);
List<Record> projectedGenericRecords = project(genericRecords,
projectedSchema);
- List<T> expectedEngineRecords =
- convertToEngineRecords(projectedGenericRecords, projectedSchema);
InputFile inputFile = encryptedFile.encryptingOutputFile().toInputFile();
- List<T> readRecords;
+
try (CloseableIterable<T> reader =
FormatModelRegistry.readBuilder(fileFormat, engineType(), inputFile)
Review Comment:
Done. I have changed all engine reads in the base now to use
`readBuilder()`, except `testReaderBuilderRecordsPerBatch`, which sets its own
batch size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
