aokolnychyi commented on a change in pull request #2166:
URL: https://github.com/apache/iceberg/pull/2166#discussion_r565729301
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -320,7 +320,7 @@ public static Distribution
buildRequiredDistribution(org.apache.iceberg.Table ta
}
}
- private static DistributionMode getDistributionMode(org.apache.iceberg.Table
table) {
+ public static DistributionMode getDistributionMode(org.apache.iceberg.Table
table) {
Review comment:
I don't like adding `get` either but the method is doing something so I
had mixed feelings. I think `distributionModeFor` may be a bit better, I'll
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
