raunaqmorarka commented on code in PR #18074:
URL: https://github.com/apache/iceberg/pull/18074#discussion_r4458889204
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -108,7 +109,10 @@ public void accept(String file) {
private final String commitUUID = UUID.randomUUID().toString();
private final AtomicInteger manifestCount = new AtomicInteger(0);
private final AtomicInteger attempt = new AtomicInteger(0);
- private final List<String> manifestLists = Lists.newArrayList();
+
+ /** Manifest paths written to each manifest list, keyed by manifest list
location. */
+ private final Map<String, Set<String>> manifestPathsByManifestList =
Maps.newHashMap();
Review Comment:
Renamed it to `manifestsByManifestList` and dropped the comment.
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -333,9 +333,9 @@ int replacedManifestsCount() {
* Deletes filtered manifests that were created by this class, but are not
in the committed
* manifest set.
*
- * @param committed the set of manifest files that were committed
+ * @param committed the set of manifest paths that were committed
Review Comment:
Restored the original comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
