rdblue commented on code in PR #18526: URL: https://github.com/apache/iceberg/pull/18526#discussion_r4461839541
########## format/spec.md: ########## @@ -2300,6 +2320,15 @@ Constraints are added in v4: * Snapshots may contain `constraint-statuses` * Upgrading a v2 or v3 table to v4 rewrites the table's `identifier-field-ids` as a `primary-key` constraint that is not enforced, unless a field cannot be used in a `primary-key` constraint +Row lineage changes: + +* When writing a manifest, ADDED entries and entries MODIFIED by column files must be written with a null `snapshot_timestamp` +* When an entry has a null `snapshot_timestamp`, readers must assign it the snapshot's `timestamp-ms` converted to microseconds in the root manifest, or the leaf manifest's `snapshot_timestamp` in a leaf manifest Review Comment: These bullet points are too low-level. This section doesn't need to restate the spec, it only needs to note that `snapshot_timestamp` and `_last_updated_time` were added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
