dannycjones commented on code in PR #3332:
URL: https://github.com/apache/iceberg-rust/pull/3332#discussion_r4468831985
##########
crates/iceberg/src/spec/values/tests.rs:
##########
@@ -485,6 +487,130 @@ fn json_map_rejects_mismatched_key_value_lengths() {
}
}
+fn nullable_nested_json_types() -> [Type; 4] {
+ [
+ Type::Struct(StructType::new(vec![
+ NestedField::optional(2, "id",
Primitive(PrimitiveType::Int)).into(),
+ ])),
Review Comment:
nit: we can now (after you authored this) just use the type without wrapping
it in the enum!
```suggestion
Type::Struct(StructType::new(vec![
NestedField::optional(2, "id", PrimitiveType::Int).into(),
])),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
