smaheshwar-pltr opened a new pull request, #1094: URL: https://github.com/apache/iceberg-cpp/pull/1094
See https://github.com/apache/iceberg/issues/17989 / https://github.com/apache/iceberg/issues/17990 for some context. Iceberg Java contains code that accesses a shared table concurrently from threads with refreshes and commits. That's caused concurrency bugs in the past. Porting that code over to `iceberg-cpp` would be worse. In Java, the JLS _defines_ a data race and so that concurrent pattern is well-defined and indivisible without synchronisation (that's not the case for all types but holds for object references). In C++, such code would be undefined behaviour, so I think it's quite valuable to have at least a comment here stating that, otherwise agents / people might port that code over resulting in UB. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
