smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r4474954129


##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -155,6 +181,9 @@ enum UpdateType {
     }
     this.endpoints = endpoints;
     this.readQueryParams = readQueryParams;
+
+    // CREATE operations need encryption configured before current metadata is 
available.
+    encryptionPropsFromMetadata(current);

Review Comment:
   TODO: See 
https://github.com/apache/iceberg/pull/13225#issuecomment-6643863317, need to 
handle the transaction case similar to Hive but without the 
https://github.com/apache/iceberg/pull/18798 bug. Or ideally a centralisation 
effort like https://github.com/apache/iceberg/pull/18799 would reduce bugs like 
this more generally



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to