fallintoplace commented on code in PR #2404:
URL: https://github.com/apache/iceberg-go/pull/2404#discussion_r4470416591
##########
table/snapshot_manifest_cache.go:
##########
@@ -361,6 +361,17 @@ func (p ManifestProvider) Manifests(ctx context.Context,
snapshot Snapshot) (ite
return slices.Values(set.borrowAllManifests()), nil
}
+// UniqueManifests yields the distinct manifest descriptors referenced by the
+// given snapshots, in first-seen order. It reads manifest lists but not the
+// manifest Avro files themselves. The caller must not modify snapshots during
+// iteration. It shares this provider's bounded cache and FileIO, with bounded
+// concurrent prefetch of historical lists. An error ends the sequence.
+func (p ManifestProvider) UniqueManifests(ctx context.Context, snapshots
[]Snapshot) iter.Seq2[iceberg.ManifestFile, error] {
Review Comment:
I've kept the method internal for now and removed the external test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
