danielcweeks commented on PR #18629: URL: https://github.com/apache/iceberg/pull/18629#issuecomment-6643405742
> I'm not sure I like the old classes absorbing the functionality from the new ValueExpressions things. It seems to be leading to a lot of branching where the classes have to behave differently based on their state and is going to push some errors into runtime that would otherwise be obvious. I don't think this is necessarily true. Anywhere a expression is used currently remains the same and everything should continue to work (parsing/visitors/evaluators/etc). Anything that is parsed into the new expression grammar would work with the new value/predicate representation. > I think it may make sense to have a parallel set of classes (UnboundValuePredicate and BoundValuePredicate) which represent the new hierarchy and live in parallel to the legacy classes (BoundSet, BoundLieteral, BoundUnary). The issue here is we would have to separate grammar structures and potentially need to support both or translate between the two. > > I'm doing some prototyping to see what the damage actually is in this approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
