mengna-lin commented on code in PR #16094:
URL: https://github.com/apache/iceberg/pull/16094#discussion_r4476715719


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -374,6 +376,46 @@ private void setColumnStatsConfig(
               });
     }
 
+    private void setColumnCompressionConfig(
+        Context context,
+        Map<String, String> colNameToParquetPathMap,
+        BiConsumer<String, CompressionCodecName> withCompressionCodec,
+        BiConsumer<String, Integer> withCompressionLevel) {
+
+      Map<String, String> columnCompressionCodec = 
context.columnCompressionCodec();
+      Map<String, String> columnCompressionLevel = 
context.columnCompressionLevel();
+
+      Sets.union(columnCompressionCodec.keySet(), 
columnCompressionLevel.keySet())

Review Comment:
   No they are independent. One column can set only the codec, only the level 
or both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to