nastra commented on code in PR #18378:
URL: https://github.com/apache/iceberg/pull/18378#discussion_r4477746578
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##########
@@ -74,6 +71,11 @@ public AuthSessionCache(String name, Duration
sessionTimeout) {
this.ticker = ticker;
}
+ @VisibleForTesting
Review Comment:
I don't think it's worth adding this method just for the sake of verifying
that this field stayed null in testing. Can you please remove it? Everything
else in this class LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
