Perseus commented on code in PR #3283:
URL: https://github.com/apache/iceberg-rust/pull/3283#discussion_r4478792480
##########
crates/iceberg/src/arrow/scan_metrics.rs:
##########
@@ -27,48 +27,122 @@ use crate::error::Result;
use crate::io::FileRead;
use crate::scan::ArrowRecordBatchStream;
-/// Wraps a [`FileRead`] to count bytes read via a shared atomic counter.
+/// The kind of file whose reads are being counted.
+pub(crate) enum ScanFileType {
Review Comment:
Ah, I didn't know that existed. Changing to use it
##########
crates/iceberg/src/arrow/scan_metrics.rs:
##########
@@ -27,48 +27,122 @@ use crate::error::Result;
use crate::io::FileRead;
use crate::scan::ArrowRecordBatchStream;
-/// Wraps a [`FileRead`] to count bytes read via a shared atomic counter.
+/// The kind of file whose reads are being counted.
+pub(crate) enum ScanFileType {
Review Comment:
Ah, I didn't see that existed. Changing to use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
