nastra commented on code in PR #18486:
URL: https://github.com/apache/iceberg/pull/18486#discussion_r4482715245
##########
core/src/main/java/org/apache/iceberg/PositionDeletesScanTask.java:
##########
@@ -18,5 +18,12 @@
*/
package org.apache.iceberg;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+
/** A {@link ScanTask} for position delete files */
-public interface PositionDeletesScanTask extends ContentScanTask<DeleteFile> {}
+public interface PositionDeletesScanTask extends ContentScanTask<DeleteFile>,
HasReferencedFiles {
+ @Override
+ default Iterable<ContentFile<?>> referencedFiles() {
Review Comment:
thanks for the explanation. I think what you have right now is probably
better than having a default impl in `ContentScanTask`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
