RussellSpitzer commented on code in PR #18791: URL: https://github.com/apache/iceberg/pull/18791#discussion_r4483057163
########## format/spec.md: ########## @@ -855,7 +855,7 @@ A manifest file must store metadata as properties in the file's key-value metada #### Content file uniqueness -Within a snapshot, each content file must be referenced by at most one live manifest entry across all manifests; otherwise, the snapshot has undefined behavior. Writers should not produce multiple manifest entries for the same content file in a snapshot (for example, both ADDED and DELETED entries for the same file). Writers are not required to validate uniqueness at commit time. +Within a snapshot, each content file must be referenced by at most one live manifest entry across all manifests; otherwise, the snapshot has undefined behavior. Writers should not produce multiple manifest entries for the same content file in a snapshot (for example, both ADDED and DELETED entries for the same file), except for the REPLACED and MODIFIED pair produced when a file is modified. Writers are not required to validate uniqueness at commit time. Review Comment: I didn't really find this text that confusing previously, and I didn't really want to step on our own feet by over-listing here and possibly making it more confusing. I would probably even just remove the whole suggestion about behavior for writers if this is confusing. The suggestion here is to encourage folks not to add and remove the file in the same commit right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
