Guosmilesmile commented on code in PR #18149:
URL: https://github.com/apache/iceberg/pull/18149#discussion_r4489950213
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/source/lookup/IcebergFullCachingLookupFunction.java:
##########
@@ -152,6 +175,10 @@ public Collection<RowData> lookup(RowData keyRow) throws
IOException {
@Override
public void close() throws Exception {
+ if (reloadTrigger != null) {
+ reloadTrigger.close();
Review Comment:
Fixed by moving it into the same try/finally chain so the cleanup still runs
and the exception is still propagated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
