wgtmac opened a new pull request, #1098: URL: https://github.com/apache/iceberg-cpp/pull/1098
LLVM 21.1.8's `clang-scan-deps` rejects digit separators in the `#if` expressions in `compat/expected.h`, even though ordinary Clang compilation accepts them. This breaks downstream CMake module dependency scanning with `-format=p1689`: ```text error: token is not a valid binary operator in a preprocessor subexpression ``` Use plain `201703L` and `202002L` literals in all nine language-version checks. The values and conditional behavior are unchanged. Validation with LLVM 21.1.8: - Reproduced nine dependency-scanning errors before the change in both C++23 and C++20 compatibility mode; the same default scanner succeeds after the change. - Compiled and ran the existing `expected_test.cc` suite in both modes: 30 tests passed in each. - `pre-commit` and `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
