akashrn5 commented on PR #18387: URL: https://github.com/apache/iceberg/pull/18387#issuecomment-6684172021
> Move the fix into `OrcSchemaWithTypeVisitor.visitVariant`. It's one file in iceberg-orc instead of 9 copies across Spark versions. It also fixes the Flink reader, which would otherwise need the separate follow-up PR the author mentioned, plus Spark 3.5, which has the same code, and any future implementations. The PR's tests can stay as they are. Thank you @pvary , makes sense. I have updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
