zhjwpku commented on code in PR #1084:
URL: https://github.com/apache/iceberg-cpp/pull/1084#discussion_r4468816905
##########
src/iceberg/util/decimal.cc:
##########
@@ -552,12 +552,26 @@ Result<Decimal> Decimal::Rescale(int32_t orig_scale,
int32_t new_scale) const {
return *this;
}
- const int32_t delta_scale = new_scale - orig_scale;
Review Comment:
This logic is originally comes from arrow[1], do we have this problem there
too?
[1]
https://github.com/apache/arrow/blame/main/cpp/src/arrow/util/basic_decimal.cc#L1054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
