kevinjqliu commented on code in PR #4159: URL: https://github.com/apache/iceberg-python/pull/4159#discussion_r4470280936
########## tests/table/encryption/README.md: ########## @@ -0,0 +1,25 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. +--> + +# Encrypted manifest list test data + +`manifest-list-v3-encrypted.avro` is an empty manifest list encrypted by iceberg-rust, copied from its Review Comment: Is there anything special about this test file (`manifest-list-v3-encrypted.avro`) that it needs to be copied over? I'd prefer to use the integration test infra to generate the encrypted avro file, if its possible. This avoids us having to keep a test file in the repo an making packaging easier. We use `dev/provision.py` to generate desired iceberg tables using spark and then those tables can be used in integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
