anoopj commented on code in PR #18699: URL: https://github.com/apache/iceberg/pull/18699#discussion_r4462783087
########## core/src/main/java/org/apache/iceberg/SnapshotValidator.java: ########## @@ -0,0 +1,578 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ExecutorService; +import java.util.stream.Collectors; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.expressions.Expressions; +import org.apache.iceberg.expressions.ManifestEvaluator; +import org.apache.iceberg.expressions.Projections; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.CloseableIterator; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.relocated.com.google.common.collect.Iterables; +import org.apache.iceberg.relocated.com.google.common.collect.Iterators; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.util.CharSequenceSet; +import org.apache.iceberg.util.ContentFileUtil; +import org.apache.iceberg.util.Pair; +import org.apache.iceberg.util.PartitionSet; +import org.apache.iceberg.util.Tasks; + +class SnapshotValidator { + // data is only added in "append" and "overwrite" operations + private static final Set<String> VALIDATE_ADDED_FILES_OPERATIONS = + ImmutableSet.of(DataOperations.APPEND, DataOperations.OVERWRITE); + // data files are removed in "overwrite", "replace", and "delete" + private static final Set<String> VALIDATE_DATA_FILES_EXIST_OPERATIONS = + ImmutableSet.of(DataOperations.OVERWRITE, DataOperations.REPLACE, DataOperations.DELETE); + private static final Set<String> VALIDATE_DATA_FILES_EXIST_SKIP_DELETE_OPERATIONS = + ImmutableSet.of(DataOperations.OVERWRITE, DataOperations.REPLACE); + // delete files can be added in "overwrite" or "delete" operations + private static final Set<String> VALIDATE_ADDED_DELETE_FILES_OPERATIONS = + ImmutableSet.of(DataOperations.OVERWRITE, DataOperations.DELETE); + // DVs can be added in "overwrite", "delete", and "replace" operations + private static final Set<String> VALIDATE_ADDED_DVS_OPERATIONS = + ImmutableSet.of(DataOperations.OVERWRITE, DataOperations.DELETE, DataOperations.REPLACE); + + private FileIO io; + private Long startingSnapshotId = null; + private boolean caseSensitive = true; + private Expression conflictDetectionFilter = null; + private ExecutorService workerPool = null; + + private TableMetadata base = null; + private Snapshot parent = null; + + private SnapshotValidator() {} + + static SnapshotValidator newValidator() { + return new SnapshotValidator(); + } + + SnapshotValidator io(FileIO newIo) { + this.io = newIo; + return this; + } + + SnapshotValidator startingSnapshotId(Long newStartingSnapshotId) { + this.startingSnapshotId = newStartingSnapshotId; + return this; + } + + SnapshotValidator caseSensitive(boolean isCaseSensitive) { + this.caseSensitive = isCaseSensitive; + return this; + } + + SnapshotValidator conflictDetectionFilter(Expression filter) { + this.conflictDetectionFilter = filter; + return this; + } + + SnapshotValidator scanWith(ExecutorService newWorkerPool) { + this.workerPool = newWorkerPool; + return this; + } + + /** + * Binds the base metadata and parent snapshot the checks run against. Needs to be invoked before + * running validations. + */ + SnapshotValidator forWindow(TableMetadata newBase, Snapshot newParent) { + this.base = newBase; + this.parent = newParent; + return this; + } + + /** + * Validates that no data files matching the conflict detection filter have been added to the + * table since the starting snapshot. + */ + void validateAddedDataFiles() { Review Comment: Thank you for the detailed analysis on this. The naming makes sense to me. In fact, the `assert*` is what I also [came up](https://github.com/anoopj/iceberg/pull/8/changes#diff-4a56687581d338d31b4ca4fb6aec4cc5326f294aaab25b949b4575266d404a5a) with originally, but I switched back to `validate` methods to be consistent with the current code and the `Validator` class name. I will update them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
