rdblue commented on a change in pull request #2129:
URL: https://github.com/apache/iceberg/pull/2129#discussion_r566456420
##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -74,6 +75,11 @@ private InputFormatConfig() {
public static final String SNAPSHOT_TABLE = "iceberg.snapshots.table";
public static final String SNAPSHOT_TABLE_SUFFIX = "__snapshots";
+ public static final String CATALOG_CONFIG_PREFIX = "iceberg.catalog.";
+ public static final String CATALOG_TYPE_TEMPLATE = CATALOG_CONFIG_PREFIX +
"%s.type";
Review comment:
I generally recommend avoiding dependencies between constants. This
pattern makes it harder to search through code to find the relevant section
that you want. And I think it is easier to read to just use
`"iceberg.catalog.%s.type"`.
That said, I would also recommend changing this so that the code extracts
catalog properties into a map (`Catalogs.getCatalogProperties`) and then get
individual keys from that map using the constants in `CatalogProperties`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
