huaxingao commented on code in PR #18776: URL: https://github.com/apache/iceberg/pull/18776#discussion_r4496793032
########## core/src/main/java/org/apache/iceberg/BaseConstraint.java: ########## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; +import java.util.Objects; +import java.util.Set; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; + +abstract class BaseConstraint implements Constraint { + private final int id; + private final String name; + private final boolean enforced; + private final long timestampMillis; + + private BaseConstraint(int id, String name, boolean enforced, long timestampMillis) { + Preconditions.checkArgument( + name != null && !name.isEmpty(), "Invalid constraint name: null or empty"); + this.id = id; + this.name = name; + this.enforced = enforced; + this.timestampMillis = timestampMillis; + } + + static CheckConstraint check( + int id, String name, boolean enforced, long timestampMillis, String expressionJson) { + return new Check(id, name, enforced, timestampMillis, expressionJson); + } + + static UniqueConstraint unique( + int id, String name, boolean enforced, long timestampMillis, List<Integer> fieldIds) { + return new Unique(id, name, enforced, timestampMillis, fieldIds); + } + + static PrimaryKeyConstraint primaryKey( + int id, String name, boolean enforced, long timestampMillis, List<Integer> fieldIds) { + return new PrimaryKey(id, name, enforced, timestampMillis, fieldIds); + } Review Comment: I kept them package-private because nothing outside `org.apache.iceberg` needs to create constraints directly. Constraints are read from JSON through `ConstraintParser`, and the public way to add them will be the `UpdateConstraints` API in a follow-up PR. Also, `check(...)` takes the expression JSON for now and will change to `Expression` later, so making it public now would make that change harder. We can make them public later if a use case comes up. ########## core/src/main/java/org/apache/iceberg/BaseConstraint.java: ########## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; +import java.util.Objects; +import java.util.Set; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; + +abstract class BaseConstraint implements Constraint { + private final int id; + private final String name; + private final boolean enforced; + private final long timestampMillis; + + private BaseConstraint(int id, String name, boolean enforced, long timestampMillis) { + Preconditions.checkArgument( + name != null && !name.isEmpty(), "Invalid constraint name: null or empty"); + this.id = id; + this.name = name; + this.enforced = enforced; + this.timestampMillis = timestampMillis; + } + + static CheckConstraint check( + int id, String name, boolean enforced, long timestampMillis, String expressionJson) { Review Comment: I agree it should be an `Expression` in the end, but `ExpressionParser` doesn't support ID references yet (#17343, #18629). Until then, I keep the expression JSON as is so it is not lost on read and write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
