mbutrovich opened a new pull request, #3653:
URL: https://github.com/apache/iceberg-rust/pull/3653

   ## Which issue does this PR close?
   
   - Closes #3646.
   - Part of #3262 (Task 2).
   
   ## What changes are included in this PR?
   
   - Build the `pyiceberg-core` wheel with `opt-level = 3` instead of `"z"`. 
The baseline in apache/iceberg-python#4007 shows the parse about 1.6x faster 
and the end-to-end read about 1.4x faster.
   - Set `strip = false`. On macOS arm64 the stripped `.so` fails to import 
with "mis-aligned LINKEDIT string pool" once the Arrow manifest readers from 
#3647 and #3648 are in the binding. It fails under `true` and `"debuginfo"` at 
both `opt-level` settings, so the failure comes from running the strip step at 
all.
   
   Sizes on macOS arm64 at `5370b61`, with the toolchain from 
`rust-toolchain.toml`:
   
   | `opt-level` | `strip` | Wheel | `.so` |
   |---|---|--:|--:|
   | `"z"` | `true` | 1.2 MB | 3.1 MB |
   | `3` | `false` | 1.8 MB | 5.6 MB |
   
   I did not build the manylinux wheels or check the `macos-latest` CI runners.
   
   ## Are these changes tested?
   
   N/A.
   
   ## AI Disclosure
   
   I wrote this PR with help from Claude but understand and support the core 
approach, implementation, and test coverage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to