Neuw84 commented on code in PR #18621:
URL: https://github.com/apache/iceberg/pull/18621#discussion_r4481967909
##########
data/src/test/java/org/apache/iceberg/data/DeleteReadTests.java:
##########
@@ -609,6 +609,44 @@ public void testEqualityDeleteBinaryColumn() throws
IOException {
testEqualityDeletes(equalityDeletes, expected);
}
+ @TestTemplate
+ public void testEqualityDeleteFixedColumn() throws IOException {
Review Comment:
Done in 09aae58. The test now follows
`testEqualityDeletesWithRequiredEqColumn`: it writes the `fixed(4)` delete file
directly and compares only `id`, so the Spark test changes are gone (the PR now
touches only `GenericRecord`, `TestGenericRecord` and `DeleteReadTests`).
Without the `GenericRecord` fix it still fails in all four
`TestGenericReaderDeletes` variants, and `TestSparkReaderDeletes` on Spark 4.2
passes unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
