chenjian2664 opened a new pull request, #4301:
URL: https://github.com/apache/iceberg-python/pull/4301
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
`load_catalog` only read `py-catalog-impl` from its keyword arguments. A
custom catalog configured in `.pyiceberg.yaml`, as the configuration docs show,
or through `PYICEBERG_CATALOG__<NAME>__PY_CATALOG_IMPL` was ignored, so loading
failed with "URI missing" or picked another catalog type. When the
implementation was passed as an argument, the custom catalog also lost the
properties from the configuration file.
`py-catalog-impl` is now read from the merged configuration, and that
configuration is passed to the custom catalog.
## Are these changes tested?
## Are there any user-facing changes?
Yes. A `py-catalog-impl` set in the configuration file or environment
variables now takes effect.
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
