mbutrovich commented on code in PR #3638: URL: https://github.com/apache/iceberg-rust/pull/3638#discussion_r4502379767
########## AGENTS.md: ########## @@ -51,6 +51,22 @@ the code they describe or they are wrong. `make generate-public-api` to update each crate's `public-api.txt`, and check its diff for API growth. +## Public API Review Comment: > should we be prescriptive here? or just mention something like "evaluate if the api needs to be public and whether it matches existing abstractions. must justify its existence to add a public api" I opened the section with your wording. I kept the specific rules as examples, because they come from review feedback that keeps repeating (derives as API, constructors that need table context, growing parameter lists). I'm happy to drop any of them if they read as too narrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
