aokolnychyi commented on a change in pull request #2179:
URL: https://github.com/apache/iceberg/pull/2179#discussion_r566479230



##########
File path: 
spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMerge.java
##########
@@ -49,9 +49,23 @@ public void removeTables() {
   }
 
   // TODO: tests for reordering when operations succeed (both insert and 
update actions)
-  // TODO: tests for modifying fields in a null struct
   // TODO: tests for subqueries in conditions
 
+  @Test
+  public void testMergeModifiesNullStruct() {

Review comment:
       The behavior matches what I tested for UPDATE in Postgres.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to