pvary commented on code in PR #18717:
URL: https://github.com/apache/iceberg/pull/18717#discussion_r4468569501
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPlanner.java:
##########
@@ -791,6 +964,16 @@ && summaryCount(summary,
SnapshotSummary.ADD_EQ_DELETE_FILES_PROP) == 0) {
return false;
}
+ private boolean addsFiles(Snapshot snapshot) {
+ Map<String, String> summary = snapshot.summary();
+ return summaryCount(summary, SnapshotSummary.ADDED_FILES_PROP) > 0
+ || summaryCount(summary, SnapshotSummary.ADDED_DELETE_FILES_PROP) > 0;
Review Comment:
Is using 0 for empty data a safe solution? Would this just skip reading
snapshots which it should read?
Also... these commits are external ones, possibly created by non-java
writers. So we should probably find a more robust fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
